Last year, I wrote about how library authors should pretty darn well never ever make their users spend time on “porting”. Porting is always a waste of time. No matter how important the library author thinks his newly fashionable way of doing stuff is, it is never ever as important as the time porting takes away from the application author’s real mission: the work on their applications. I care foremost about my users; I expect a library author to care about their users, i.e, people like me.
So, today I was surprised by Goodbye, Q_FOREACH by Marc Mutz. (Well known for his quixotic crusade to de-Qt Qt.)
Marc, none, not a single one of all of the reasons you want to deprecate Q_FOREACH is a reason I care even a little bit about. It’s going to be deprecated? Well, that’s a decision, and a dumb one. It doesn’t work on std containers, QVarLengthArray or C arrays? I don’t use it on those. It adds 100 bytes of text size? Piffle. It makes it hard to reason about the loop for you? I don’t care.
What I do care is the 1559 places where we use Q_FOREACH in Krita. Porting this will take weeks.
Marc, I hope that you will have a patch ready for us on phabricator soon: you can add it to this project and keep iterating until you’ve fixed all the bugs.
Happy porting, Marc!
Come into the real world and learn how well this let’s-deprecate-and-let-the-poor-shmuck-port-their-code attitude works out.